Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Implement equals for the ImmutableMetadata object #512

Merged
merged 2 commits into from
Jul 17, 2023
Merged

fix: Implement equals for the ImmutableMetadata object #512

merged 2 commits into from
Jul 17, 2023

Conversation

thomaspoignant
Copy link
Member

This PR

  • Implement the equals method to be able to compare 2 FlagEvaluationDetails.

Related Issues

Fixes #511

@thomaspoignant thomaspoignant requested a review from a team as a code owner July 17, 2023 06:15
@thomaspoignant
More generic error text
a60644a 
Signed-off-by: Thomas Poignant <[email protected]>
@sonarcloud
Copy link

sonarcloud bot commented Jul 17, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

No Coverage information No Coverage information
0.0% 0.0% Duplication

@thomaspoignant thomaspoignant added the bug Something isn't working label Jul 17, 2023
@codecov
Copy link

codecov bot commented Jul 17, 2023 •
edited
Loading

Codecov Report

Merging #512 (a60644a) into main (bbb4008) will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##               main     #512   +/-   ##
=========================================
  Coverage     95.23%   95.23%           
  Complexity      329      329           
=========================================
  Files            31       31           
  Lines           755      755           
  Branches         37       37           
=========================================
  Hits            719      719           
  Misses           19       19           
  Partials         17       17
Flag Coverage Δ
unittests 95.23% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...in/java/dev/openfeature/sdk/ImmutableMetadata.java 100.00% <ø> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@thomaspoignant thomaspoignant mentioned this pull request Jul 17, 2023
Merged
toddbaert
toddbaert approved these changes Jul 17, 2023
View reviewed changes
Copy link
Member

@toddbaert toddbaert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me.

If there's more types we should do this with, we can address it as a separate PR.

@thomaspoignant thomaspoignant merged commit 6253aee into open-feature:main Jul 17, 2023
8 checks passed
@github-actions github-actions bot mentioned this pull request Jul 14, 2023
Merged
@thomaspoignant thomaspoignant deleted the fix-511 branch July 17, 2023 14:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@toddbaert toddbaert toddbaert approved these changes

@Kavindu-Dodan Kavindu-Dodan Awaiting requested review from Kavindu-Dodan

Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Implement equals for the ImmutableMetadata object
2 participants
@thomaspoignant @toddbaert